Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

280 file upload change requests #281

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from
Open

280 file upload change requests #281

wants to merge 4 commits into from

Conversation

markostreich
Copy link
Contributor

Description

Change requests after review.

  • The border of the upload box should have a thickness of 1px instead of 2px, like the input field.
  • Error text wrapping: If an error text spans two lines, the second line should start to the right of the info icon.
  • The icon before the error text should be the filled version of the info icon, not the outline version.

Reference

Issues #280

@markostreich markostreich self-assigned this Oct 21, 2024
@markostreich markostreich linked an issue Oct 21, 2024 that may be closed by this pull request
File Upload change requests #280
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianWilms FabianWilms Awaiting requested review from FabianWilms

At least 1 approving review is required to merge this pull request.

Assignees

@markostreich markostreich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Upload change requests
1 participant
@markostreich