current envoy fips builds need ncurses 6

[ceastman-r7]

envoy recently updated their code to require ncurses 6 for fips builds to be successful.

[istio-policy-bot]

😊 Welcome @ceastman-r7! This is either your first contribution to the Istio tools repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[istio-testing]

Hi @ceastman-r7. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[howardjohn]

This is doing a lot more than ncurses but also changing the base OS which is a major breaking change. Also, I think a lot of people are building FIPS mode currently so I am not sure its accurate we need a change? Unless its very recent?

[ceastman-r7]

@howardjohn looks like it started between istio 1.18.2 and 1.18.3 with regards to when ncurses 6 became necessary.

@kyessenov do you know which envoy release the ncurses 6 became necessary?

@howardjohn besides building images with focal, how else can we test the upgraded os is fine?

[kyessenov]

I don't know - if you do some reverse engineer to find out what pulls ncurses, that can help.

[heschlie]

So I have been fighting this same issue and can confirm that bumping to focal fixes this as focal includes libncurses6. It looks like this should have broken in May of last year when envoy changed the build from clang 7 to 12 which also changed the download from a binary compatible with 16.04 to 20.04 here but I would find it hard to believe no one ran into this before October, or maybe folks did but just figured it out and never reported it.

[istio-testing]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.