Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.23] client sidecar metadata fallback #6076

Open
wants to merge 3 commits into
base: release-1.23
Choose a base branch
from

Conversation

keithmattix
Copy link
Contributor

Cherry-pick of #6028

@keithmattix keithmattix requested a review from a team as a code owner January 16, 2025 16:28
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2025
* Add metadata fallback for client sidecar reporters

Signed-off-by: Keith Mattix II <[email protected]>

* Move logic

Signed-off-by: Keith Mattix II <[email protected]>

* Add test

Signed-off-by: Keith Mattix II <[email protected]>

* Fix compiler error

Signed-off-by: Keith Mattix II <[email protected]>

* Fixup

Signed-off-by: Keith Mattix II <[email protected]>

* Fix ownership bug

Signed-off-by: Keith Mattix II <[email protected]>

* Don't use string_view because of scope

Signed-off-by: Keith Mattix II <[email protected]>

---------

Signed-off-by: Keith Mattix II <[email protected]>
* Add compdb script:

Signed-off-by: Keith Mattix II <[email protected]>

* Add license

Signed-off-by: Keith Mattix II <[email protected]>

* Fix shebang

Signed-off-by: Keith Mattix II <[email protected]>

---------

Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix keithmattix force-pushed the 1-23-client-sidecar-metadata-fallback branch from 7f6013a to e4de366 Compare January 16, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants