New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect coverage for Vue files #711
base: main
Are you sure you want to change the base?
Conversation
@marekdedic Regarding #707, this seems to fix it for me. |
dependencies from
part of the
part of the
|
This was a full project in my previous message
Shereef/graphql-jest-coverage-attribute@main...coverage-fix-test |
I've installed the patched version and can confirm it works, the coverage report line numbers as well as the coverage percentages are working again. |
Would like to bump this as fix as it resolves issues I'm facing on a project. Thanks for the hard work to all involved 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ergh, actually - should we parse it if it's a string? |
I don't know :D I don't know why encoded json is passed as the source map in the first place :D |
I think I'd like to see a test added before merging this - anybody up for contributing one? |
da8dd0f
to
5a5251b
Compare
This somehow fixes the Vue error described in the comments of #707.
I have no idea how this works, but at least in https://github.com/rklos/istanbul-lib-instrument-repro it seems a string is passed as the
inputSourceMap
and it contains the following:Yes, that actually is a JSON encoded value, passed as a string.