Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markup and styling for coverage report #674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hogansghost
Copy link

I've tried to leave the template files alone as much as possible, beyond adding the updated class names, but this is mostly a complete update for the CSS with modern approaches with as wide support as possible. I'm not overly attached to the colours or anything, they were just tweaked to feel a little more modern.

No more horizontal scrolling for the entire document either anymore on narrower screens!

  • Rewrite CSS with modern standards and BEM naming for clarity within the code.
    We're replacing the util classes with explicit naming to make it easier
    to discern what is what.
  • Update colours to make use of CSS vars and tweak values.
  • Update markup, where possible, to modern semantic elements, updating their
    class names and structure.
  • Replace sorting icons with ASCII characters instead of images and wrap in buttons
    to make keyboard accessible for sorting.
  • Delete now unused graphics for sorting icons.
  • Remove import of unused graphics for sorting icons.
  • Change document wrapper functions into single function that accepts
    all the other template elements as a string argument, so we no
    longer need multiple .write functions and separated opening and
    closing <body> functions.

Screenshot 2022-02-20 at 14 09 58

Screenshot 2022-02-20 at 14 10 02

Screenshot 2022-02-20 at 14 10 16

Screenshot 2022-02-20 at 14 10 23

Screenshot 2022-02-20 at 14 10 27

Screenshot 2022-02-20 at 14 10 31

Screenshot 2022-02-20 at 14 10 34

Screenshot 2022-02-20 at 14 10 37

Screenshot 2022-02-20 at 14 10 41

Screenshot 2022-02-20 at 14 10 49

Screenshot 2022-02-20 at 14 10 51

- Rewrite CSS with modern standards and BEM naming for clarity within the code.
  We're replacing the util classes with explicit naming to make it easier
  to discern what is what.
- Update colours to make use of CSS vars and tweak values.
- Update markup, where possible, to modern semantic elements, updating their
  class names and structure.
- Replace sorting icons with ASCII characters instead of images and wrap in buttons
  to make keyboard accessible for sorting.
- Delete now unused graphics for sorting icons.
- Remove import of unused graphics for sorting icons.
- Change document wrapper functions into single function that accepts
  all the other template elements as a string argument, so we no
  longer need multiple `.write` functions and separated opening and
  closing `<body>` functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant