Refactor UI, models, & related infra #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
isiahmanns
commented
Sep 11, 2023
•
isiahmanns
commented
- Timers lengths are now provided for user, reducing Settings
- Timer grid layout is updated
- Timer Category Toggle enables any timer to be selected as a focus or rest block
- New grid iteration
- Closes Redesign UI #176
- Closes Migrate UI into NSWindow #182
- Closes Remove AnalyticsManager enum, use specific type names #175
- Closes Split unit tests up by dependencies #179
- Closes Create/release About window as needed #183
- Provide default timer lengths - Remove timer settings - Remove timer preset analytics - Refactor Timer.Model - Convert timer category to static property - Remove timer "t-shirt" size - Remove disabled state - Convert timer length to a let constant - Refactor timer grid layout
isiahmanns
changed the title
isiahmanns
changed the title
isiahmanns
force-pushed
the
feature/ui-redesign
branch
from
4ab8cc9
to
2f19a14
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
4 times, most recently
from
e7b9053
to
b1d12fc
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
2 times, most recently
from
cd53eb1
to
6300d2e
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
from
6300d2e
to
cbcc9ee
Compare
Additionally: - Simplify Analytics type composition (#175)
Additionally: - Make TimerCategoryToggle type the owner of static category property
- Move timer category static property off of toggle presenter model to the TimerCategory type - Instead of reading timer category static property at different points during state change, read from TimerManager and inject via TimerEvent publisher as source of truth
isiahmanns
force-pushed
the
feature/ui-redesign
branch
7 times, most recently
from
c4f349c
to
e3e5402
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
from
e3e5402
to
1c5690d
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
14 times, most recently
from
3dc43cd
to
e4f78b6
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
from
23014fa
to
0560fb0
Compare
isiahmanns
force-pushed
the
feature/ui-redesign
branch
from
b876a35
to
5dd0b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.