[WIP] 2.0.0 #39
Merged
[WIP] 2.0.0 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed int to bool conversion.
|
Reviewed 3 of 9 files at r1, 15 of 18 files at r2. JSONHelper/Extensions/Bool.swift, line 43 [r2] (raw file): JSONHelper/Extensions/Bool.swift, line 45 [r2] (raw file): JSONHelper/Extensions/Color.swift, line 11 [r2] (raw file): JSONHelper/Extensions/String.swift, line 35 [r2] (raw file): Comments from the review on Reviewable.io |
isair
force-pushed
the
dev-2.0.0
branch
6 times, most recently
from
4d5d759
to
a153bfc
Compare
Additionally: - Bumped version to 2.0.0. - Completed more tests. - Minor code refactoring. - Commented out JSONAPI code temporarily.
These commits will be squashed, so I'm going to detail these later on.
Additional changes: - NSDate to String conversion. - Serializable protocol.
isair
force-pushed
the
dev-2.0.0
branch
5 times, most recently
from
c00e77d
to
9967b14
Compare
Except serialization and JSON API support.
# Conflicts: # JSONHelper/JSONHelper.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better structured JSONHelper with support for serialization (will be completed with 2.1.0) as well as deserialization. Also adds additional type conversions that were not supported previously.
Closes #37, closes #23, closes #14, closes #7, closes #43.
┆Issue is synchronized with this Asana task