Use venv in CI #379
Open
Use venv in CI #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
ScottTodd
reviewed
Jan 10, 2025
Comment on lines
+49
to
+50
| source ${VENV_DIR}/bin/activate | ||
| echo PATH=$PATH >> $GITHUB_ENV |
There was a problem hiding this comment.
This does not keep the venv active across job steps from what I can tell.
See that the logs are not using .turbine-venv: https://github.com/iree-org/iree-turbine/actions/runs/12714371230/job/35446471647?pr=379#step:5:20
I usually explicitly activate the venv in each step that needs it.
There was a problem hiding this comment.
Since the jobs in this file run on ephemeral github-hosted machines, using a virtual environment is less important. Could keep the file as-is, with pip caching.
Not that much of a difference in time though:
- Before: https://github.com/iree-org/iree-turbine/actions/runs/12675726967/job/35327371540 (restores a 200MB cache from github then installs packages from it, takes ~20 seconds)
- This PR: https://github.com/iree-org/iree-turbine/actions/runs/12714371228/job/35444294575?pr=379 (downloads packages from pypi and installs them, takes ~20 seconds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.