[broken][IREE] Update IREE submodule and make compile (but not pass CI). #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch was done in bb6d12b in the LLVM mono repo.
This was done in abc362a1 of the LLVM mono repo.
The NoSideEffect and RecursiveSideEffect traits used until now were removed by 86771d0b in the LLVM mono repo. I *believe* that the new NoMemoryEffect and RecursiveMemoryEffect as used in this commit are conservative replacements, i.e., they will result in correct usages but may disallow optimizations that were previously possible. Since I do not understand the affected ops sufficiently, I do not dare to add the more poerful traits.
That function has been deprecated for a while and removed in 4b6b248 in the LLVM mono repo.
llvm::None has been deprecated by bd6a170 in the LLVM mono repo.
ingomueller-net
force-pushed
the
update-iree-sandbox
branch
from
fc41e8c to
69aca2c
Compare
|
@nicolasvasilache: FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects the changes I made while attempting to update the whole sandbox to the latest (Jan 10, 2023) version of the IREE submodule. I eventually gave up because of issues in the CMake files of that repository that I couldn't resolve in CI. The commits here can still serve if an update should be done at a later stage.