feat!: use latest ipld-explorer-components #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
changed the title
SgtPooki
commented
Oct 18, 2024
Comment on lines
+8
to
+26
| test('should resolve a dag-pb cid with a path', async ({ page }) => { | ||
| await page.goto('/') | ||
| const waitForTitle = async (title) => { | ||
| await page.waitForFunction(`document.title === '${title}'`, { timeout: 5000 }) | ||
| } | ||
|
|
||
| await waitForTitle('Explore - IPLD') | ||
|
|
||
| // Focus the explore form, type a path, hit enter to submit | ||
| await page.click('#ipfs-path') | ||
| await page.fill('#ipfs-path', 'QmS4ustL54uo8FzR9455qaxZwuMiUhyvMcX9Ba8nUH4uVv/readme') | ||
| await page.keyboard.press('Enter') | ||
|
|
||
| // Expect the CID for the path target to have resolved | ||
| await page.waitForSelector('[data-id=ObjectInfo-cid]') | ||
| const resolvedCid = await page.$eval('[data-id=ObjectInfo-cid]', el => el.innerText) | ||
| expect(resolvedCid).toEqual('QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB') | ||
| expect(await page.title()).toBe('Exploring - IPLD') | ||
| }) |
There was a problem hiding this comment.
finally converted the puppeteer test to playwright
Comment on lines
+6
to
+7
| file_filter = public/locales/<lang>/app.json | ||
| source_file = public/locales/en/app.json |
There was a problem hiding this comment.
use the new namespace files, so we can get translations from ipld-explorer-components (they can still be overridden)
src/App.jsx
Outdated
Comment on lines
6
to
29
| const Page = () => { | ||
| const [route, setRoute] = useState(window.location.hash.slice(1) ?? '/') | ||
|
|
||
| useEffect(() => { | ||
| const onHashChange = () => { setRoute(window.location.hash.slice(1) ?? '/') } | ||
| window.addEventListener('hashchange', onHashChange) | ||
| return () => { window.removeEventListener('hashchange', onHashChange) } | ||
| }, []) | ||
|
|
||
| const RenderPage = () => { | ||
| switch (true) { | ||
| case route.startsWith('/explore'): | ||
| return <ExplorePage /> | ||
| case route === '/': | ||
| default: | ||
| return <StartExploringPage /> | ||
| } | ||
| } | ||
|
|
||
| return ( | ||
| <RenderPage /> | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
simple router component
src/App.jsx
Outdated
| render() { | ||
| const { showUpdateAvailable } = this.state | ||
| const Page = this.props.route | ||
| const { embed } = this.props.queryObject | ||
| const embed = false |
There was a problem hiding this comment.
explore.ipld.io should never be "embedded", it's its own page.
| @@ -25,88 +17,50 @@ export const viteConfig = (configEnv = {}) => { | |||
| } | |||
| } | |||
| /** | |||
| * @type {typeof import('vite').UserConfigExport} | |||
| * @type {import('vite').UserConfigExport} | |||
There was a problem hiding this comment.
fixed type resolution
| } | ||
|
|
||
| export default defineConfig(viteConfig); | ||
| export default defineConfig(viteConfig) |
There was a problem hiding this comment.
we no longer needed a lot of this since the ipld-explorer-components is updated and outputting a more usable bundle now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: This is incorporating the new ipld-explorer-components updates from ipfs/ipld-explorer-components#448
Primary changes:
explore.jsontoapp.json. They can override translations provided by ipld-explorer-components if desired.