Decouple system config from user overrides in ipfs/conf
#9000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #8925.
Still a WIP (there are still decisions that need to be made and broken tests to be fixed), but it has enough content to start the review process.
Some notes (will flesh this out later):
UserConfigOverrides
is introduced in the middle of the coupling of systemConfig
and user JSON.ipfs/conf
file.Repo
interface, reworking it to use this new type where possible.Config
is now explicit in the user config file.