Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple system config from user overrides in ipfs/conf #9000

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented May 31, 2022

Toward #8925.

Still a WIP (there are still decisions that need to be made and broken tests to be fixed), but it has enough content to start the review process.

Some notes (will flesh this out later):

  • A new type UserConfigOverrides is introduced in the middle of the coupling of system Config and user JSON .ipfs/conf file.
  • The PR was written around the Repo interface, reworking it to use this new type where possible.
  • The profiles, before implicit in the serialized Config is now explicit in the user config file.
  • There are pending decisions around the config UX having in mind reducing the impact on the user. In general we default to behaving as much as possible as we have been doing.

@schomatis schomatis requested a review from lidel May 31, 2022 15:42
@schomatis schomatis self-assigned this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

1 participant