Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo in HTTPGatewayRouter class name #664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix typo in HTTPGatewayRouter class name #664

wants to merge 1 commit into from

Conversation

achingbrain
Copy link
Member

Gatway -> Gateway

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner October 24, 2024 10:30
@achingbrain
Copy link
Member Author

Ah, the typo is in the exported interface name as well 🤦

export interface HTTPGatwayRouterInit {

@2color
Copy link
Member

2color commented Dec 16, 2024

Ah, the typo is in the exported interface name as well 🤦

export interface HTTPGatwayRouterInit {

So fixing that would technically be a breaking change, requiring a major bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @2color @SgtPooki