Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove want-block sent tracking from sessionWantSender #759

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gammazero
Copy link
Contributor

Tracking want-blocks that were sent to a peer is not necessary to do in sessionwantsender. This is already handled in peermanager/peerwantmanager.

Removing this tracking reduces unnecessary memory use.

Tracking want-blocks that were sent to a peer is not necessary to do in sessionwantsender. This is already handled in peermanager/peerwantmanager.

Removing this tracking reduces unnecessary memory use.
@gammazero gammazero requested a review from a team as a code owner December 16, 2024 22:18
@gammazero gammazero changed the title Remove want-block sent tracking Remove want-block sent tracking from sessionWantSender Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.40%. Comparing base (3cee549) to head (a7f6755).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   60.46%   60.40%   -0.07%     
==========================================
  Files         245      244       -1     
  Lines       31126    31094      -32     
==========================================
- Hits        18821    18782      -39     
- Misses      10629    10634       +5     
- Partials     1676     1678       +2     
Files with missing lines Coverage Δ
...tswap/client/internal/session/sessionwantsender.go 97.56% <100.00%> (+0.61%) ⬆️

... and 14 files with indirect coverage changes

@lidel lidel requested a review from hsanjuan December 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant