test(many): replace ionic buttons in e2e tests with native html buttons #29422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Apr 30, 2024
| @@ -143,7 +152,7 @@ <h3>mode: md</h3> | |||
| dynamicHomeIcon.name = 'home'; | |||
| dynamicHomeIcon.isActive = false; | |||
|
|
|||
| icons = ['home', 'star', 'ios-alert', 'ios-alert-outline', 'md-alert', 'logo-apple']; | |||
| icons = ['home', 'star', 'alert-circle', 'alert-circle-outline', 'alert-circle-sharp', 'logo-apple']; | |||
There was a problem hiding this comment.
I updated this to use the latest Ionicon names by comparing the older names with the v3 Ionicons to see what it should be now: https://ionicframework.com/docs/v3/ionicons
brandyscarney
commented
Apr 30, 2024
core/scripts/testing/styles.css
Outdated
|
|
||
| button { | ||
| display: block; | ||
| width: 100%; |
There was a problem hiding this comment.
I chose to default to 100% width here because it seemed the more common use case, but I could be convinced to make an inline, auto-width button the default if we prefer that.
There was a problem hiding this comment.
Spoke with the team during office hours. We decided to update the button to be inline-block by default and then add a class called expand which replaces the old expand="block" behavior that using an ion-button had.
brandyscarney
force-pushed
the
bc/remove-button-tests-main
branch
from
e84370a
to
92792d5
Compare
2 tasks
sean-perkins
reviewed
May 2, 2024
Co-authored-by: ionitron <[email protected]>
brandyscarney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
ion-buttoncomponent is used in several tests to navigate or show overlays. This causes screenshot diffs in unrelated tests any time the UI of theion-buttonis updated.What is the new behavior?
Removes the
ion-buttonelements from unrelated tests.Did not remove the
ion-buttons from the following tests:ion-buttons in anion-buttonscomponention-buttoninside of a menuUpdates the icon/basic test to use the right icon names by comparing against the v3 names: https://ionicframework.com/docs/v3/ionicons/
Does this introduce a breaking change?