Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(picker): picker column is easier to select with assistive technology #29371

Merged
merged 30 commits into from
Apr 24, 2024
Merged

feat(picker): picker column is easier to select with assistive technology #29371

merged 30 commits into from
Apr 24, 2024

Commits on Apr 16, 2024

  1. feat(picker): add stubbed assistive cover implementation

    @liamdebeasi
    liamdebeasi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4be5ab8 View commit details
    Browse the repository at this point in the history

  2. feat: implement arrow up, down, home, end, and aria label

    @liamdebeasi
    liamdebeasi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a71f009 View commit details
    Browse the repository at this point in the history

  3. fix: do not focus underlying scroll container

    @liamdebeasi
    liamdebeasi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0224617 View commit details
    Browse the repository at this point in the history

  4. fix: remove focus ring

    @liamdebeasi
    liamdebeasi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    77502c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. fix: old div no longer receives keyboard focus

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8ca4fe6 View commit details
    Browse the repository at this point in the history

  2. fix: valuetext uses label from active option

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    004ee5f View commit details
    Browse the repository at this point in the history

  3. feat: implement pageup/pagedown behaviors

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b460f31 View commit details
    Browse the repository at this point in the history

  4. remove log

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a5a7a4d View commit details
    Browse the repository at this point in the history

  5. add correct max count

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0359786 View commit details
    Browse the repository at this point in the history

  6. add comments

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    36271d7 View commit details
    Browse the repository at this point in the history

  7. more comments

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5dbad1a View commit details
    Browse the repository at this point in the history

  8. use single selector

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    98b6a92 View commit details
    Browse the repository at this point in the history

  9. strict null checks

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    aa8f2b6 View commit details
    Browse the repository at this point in the history

  10. init var to null

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5fcee5d View commit details
    Browse the repository at this point in the history

  11. get valuenow without extra iteration

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cd70c0f View commit details
    Browse the repository at this point in the history

  12. fix: max count is correct

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8630ccc View commit details
    Browse the repository at this point in the history

  13. add attribute tests

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a2d6685 View commit details
    Browse the repository at this point in the history

  14. remove debug background

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    bf6b621 View commit details
    Browse the repository at this point in the history

  15. add accessible labels for datetime picker integration

    @liamdebeasi
    liamdebeasi committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    aabd368 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix: announce values as uses slides

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d3fd294 View commit details
    Browse the repository at this point in the history

  2. revert refactor, fix ios behavior

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0917f0e View commit details
    Browse the repository at this point in the history

  3. typo

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    251c2fd View commit details
    Browse the repository at this point in the history

  4. fix: nvda does not announce wrong valuetext value

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cddae95 View commit details
    Browse the repository at this point in the history

  5. remove unneeded tests

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c0c62c9 View commit details
    Browse the repository at this point in the history

  6. remove log

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5a2b23e View commit details
    Browse the repository at this point in the history

  7. improve behavior on mobile

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7139d44 View commit details
    Browse the repository at this point in the history

  8. lint

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    33bd32d View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/feature-8.1' into FW-1891

    @liamdebeasi
    liamdebeasi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c6b8b87 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Update core/src/components/picker-column/picker-column.tsx 

    Co-authored-by: Sean Perkins <[email protected]>
    @liamdebeasi @sean-perkins
    liamdebeasi and sean-perkins authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5a213d2 View commit details
    Browse the repository at this point in the history

  2. chore: remove redundant type

    @liamdebeasi
    liamdebeasi authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    294d771 View commit details
    Browse the repository at this point in the history