feat(range): add label prop #27408
Merged
feat(range): add label prop #27408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
package: angular
averyjohnston
requested review from
a team,
liamdebeasi and
sean-perkins
as code owners
thetaPC
reviewed
May 5, 2023
| @@ -125,6 +125,32 @@ configs().forEach(({ title, screenshot, config }) => { | |||
| expect(await range.screenshot()).toMatchSnapshot(screenshot(`range-items-fixed`)); | |||
| }); | |||
| }); | |||
|
|
|||
| test.describe('range: label prop', () => { | |||
There was a problem hiding this comment.
Should this be limited to only one mode and one direction? The label prop doesn't change functionality regardless of mode/direction.
There was a problem hiding this comment.
I intentionally left all the configs in because the prop needed some styling separate from the slot, so I figured it would be good to verify no visual regressions in all cases, but I could go either way on it, honestly.
There was a problem hiding this comment.
If the majority is okay as is, then I can be on board.
sean-perkins
requested changes
May 6, 2023
sean-perkins
requested changes
May 6, 2023
liamdebeasi
suggested changes
May 8, 2023
liamdebeasi
suggested changes
May 8, 2023
mapsandapps
approved these changes
May 8, 2023
sean-perkins
approved these changes
May 9, 2023
liamdebeasi
reviewed
May 9, 2023
|
Docs PR created: ionic-team/ionic-docs#2955 |
liamdebeasi
reviewed
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Labels on
ion-rangecan only be set via thelabelslot. When only plain text is needed, this is cumbersome because you need to add an entire new element to wrap the label.What is the new behavior?
Label prop added. If both the prop and slot are used, the prop will take priority.
Does this introduce a breaking change?
Other information
7.0.6-dev.11683657201.139d03f4