feat(dark-theme): import dark theme from core #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested review from
a team and
averyjohnston
and removed request for
a team
thetaPC
commented
Jan 10, 2024
| @@ -17,7 +17,7 @@ | |||
| "generate": "stencil generate" | |||
| }, | |||
| "dependencies": { | |||
| "@ionic/core": "^7.5.0" | |||
| "@ionic/core": "7.6.2-dev.11704729332.13b412c8" | |||
There was a problem hiding this comment.
The dev build is needed in order to import the dark theme files. This will be reverted once the feature is released. Jira ticket has been created.
thetaPC
commented
Jan 10, 2024
| @@ -9,7 +9,7 @@ export class AppHome { | |||
| components = getComponents(); | |||
|
|
|||
| toggleDarkMode = () => { | |||
| document.body.classList.toggle('dark'); | |||
| document.documentElement.classList.toggle('ion-theme-dark'); | |||
There was a problem hiding this comment.
The dark.class stylesheet expects .ion-theme-dark to be set on the root.
averyjohnston
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
Docs demo is setting the Ionic dark theme through a file within the project.
What is the new behavior?
Docs demo is setting the Ionic dark theme through
@ionic/core.I removed the custom styling since the title has a color of
#fffwith or without it.Does this introduce a breaking change?
Other information
N/A