Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctests #79

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix doctests #79

wants to merge 4 commits into from

Conversation

cjwatson
Copy link

@cjwatson cjwatson commented Jul 8, 2024

The doctests weren't being run and had bitrotted. Make them work again.

cjwatson added 3 commits July 8, 2024 23:11
The doctests weren't being run and had bitrotted.  Make them work again.
macos-latest doesn't seem to have working binaries for these.
@oldium
Copy link

oldium commented Jul 26, 2024

I see that you covered almost all of my fixes from #73. Would you mind including also d20820a, so that your fix PR is complete? I will then rebase on top of your PR.

This fixes `CoverageWarning: Couldn't parse Python file
'.../tests/badsyntax.py' (couldnt-parse)`.

Based on a change by Oldřich Jedlička.
@cjwatson
Copy link
Author

cjwatson commented Aug 2, 2024

@oldium Thanks for the suggestion! I think that change is very slightly too broad: coverage data for tests is good (because it makes it harder to have test code that's accidentally never executed, e.g. due to two test cases having the same function names), but of course it doesn't make sense to run coverage on some of these examples. I made a similar commit 4756288, which just omits tests/bad*.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants