fix(ui): allow invoke when inpaint/raster layers are empty #7410
+109
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Dec 2, 2024
hipsterusername
approved these changes
Dec 2, 2024
Removed the empty state checks for these layer types - it's always OK to invoke when they are empty.
hipsterusername
force-pushed
the
psyche/fix/ui/empty-layer-cannot-invoke
branch
from
63ed20f
to
2dddc65
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #7388, I updated the "ready to invoke" logic to handle FLUX's limitations with Regional Guidance. I added empty layer checks for inpaint mask and raster layers while on autopilot.
These layer types are allowed to be empty. Removed the checks.
Related Issues / Discussions
Reported offline
QA Instructions
You should be able to invoke w/ empty inpaint masks or raster layers.
Merge Plan
n/a
Checklist