Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gguf importing #7405

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

JPPhoto
Copy link
Contributor

@JPPhoto JPPhoto commented Nov 30, 2024

Summary

Importing a gguf file results in:

Exception: The model file "blah.gguf" is potentially infected by malware. Aborting import.

This happens because gguf files are scanned for malware and return an error; the file format does not suffer from the same problems as pickled files and does not need to be scanned.

This PR removes the scan from gguf files but keeps it for other potentially-unsafe formats.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files labels Nov 30, 2024
@psychedelicious
Copy link
Collaborator

Good catch, thanks JP!

@psychedelicious psychedelicious enabled auto-merge (rebase) December 2, 2024 22:22
@psychedelicious psychedelicious force-pushed the JPPhoto-fix-gguf-loading branch from cab2cdd to 89b5387 Compare December 2, 2024 22:22
@psychedelicious psychedelicious merged commit c094838 into invoke-ai:main Dec 2, 2024
14 checks passed
@JPPhoto JPPhoto deleted the JPPhoto-fix-gguf-loading branch December 3, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants