fix: Fail scan on InvalidMagicError in picklescan, update default for… #7381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
lstein,
blessedcoolant,
RyanJDick,
hipsterusername and
psychedelicious
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Nov 25, 2024
… read_checkpoint_meta to scan unless explicitly told not to
brandonrising
force-pushed
the
brandon/improve-scanning-of-models
branch
from
7660bdb to
756008d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… read_checkpoint_meta to scan unless explicitly told not to
Summary
Update our picklescan usage to no longer ignore scan errors.
Update read_checkpoint_meta in model_util.py to default to running scans
QA Instructions
Corrupt a ckpt file and scan it. Ensure it fails scanning in the probe.
Merge Plan
Can be merged when approved
Checklist
What's Newcopy (if doing a release after this PR)