Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add empty state for regional guidance ref image #7363

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

Adds empty state for reference images, like we have for control adapters.

Screen.Recording.2024-11-20.at.1.19.10.pm.mov
  • Empty state for regional guidance reference images
  • Empty state for global reference images

Related Issues / Discussions

offline discussion

QA Instructions

One caveat - we don't track whether or not it is the first time that you have selected an image. When you click the reset icon in the corner of the reference image image, we fall back to the empty state.

This differs from the current behaviour, where clicking the reset icon only empties the image - the rest of the ref image settings are still displayed, with the image box being a placeholder. You can see this in the video.

We'll need to make some deeper changes if we want to track whether or not this is the first time the user has selected a reference image for a given layer.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Nov 20, 2024
@psychedelicious psychedelicious marked this pull request as ready for review November 21, 2024 16:48
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/ref-image-defaults branch from 27a7bd2 to 3d20fc9 Compare November 21, 2024 16:48
@psychedelicious psychedelicious enabled auto-merge (rebase) November 21, 2024 16:48
@psychedelicious psychedelicious merged commit 92f71d9 into main Nov 21, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/ref-image-defaults branch November 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants