Fixes for XInvoice #9523
Merged
Fixes for XInvoice #9523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently waiting on horstoeko/zugferd#49 |
|
Ready for rewiev. See the questions above |
turbo124
reviewed
May 17, 2024
turbo124
reviewed
May 17, 2024
|
@turbo124 done the requested changes. Could you please review my questions above? |
turbo124
reviewed
May 17, 2024
turbo124
reviewed
May 17, 2024
|
@turbo124 , just mentioned you again in the open questions. Will fix the rest later |
|
@LarsK1 I think the questions are not in this repo's contexts, but your own? I'm not receiving notifications on these unfortunately so I am unable to track. Can you ping me on Slack to discuss? |
|
@turbo124 ready for final review |
turbo124
approved these changes
May 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.