Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ios enrollmentDate -> enrollmentTime #7653

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mnahkies
Copy link
Contributor

@mnahkies mnahkies commented Feb 26, 2024

Description

rename enrollmentDate -> enrollmentTime on iOS to match Android/Web (ref: https://firebase.google.com/docs/reference/js/auth.multifactorinfo)

keep enrollmentDate around on ios for backwards compatibility, mark as deprecated.

ref:

BREAKING CHANGE: enrollmentDate renamed to enrollmentTime on iOS

split from #7565

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 7:23am

@mnahkies mnahkies changed the title fix!: ios enrollmentDate -> enrollmentTime fix: ios enrollmentDate -> enrollmentTime Mar 9, 2024
@mnahkies
Copy link
Contributor Author

mnahkies commented Mar 9, 2024

@mikehardy I've adjusted this to be backwards compatible since I missed the v19 release, it would be great if you could take a look 🙏

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Merging #7653 (ec3ea1b) into main (fae5966) will decrease coverage by 34.82%.
Report is 15 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7653       +/-   ##
===========================================
- Coverage   68.05%   33.23%   -34.82%     
===========================================
  Files         149      251      +102     
  Lines        5943    12463     +6520     
  Branches     1250     1944      +694     
===========================================
+ Hits         4044     4141       +97     
- Misses       1802     8233     +6431     
+ Partials       97       89        -8     

Copy link

github-actions bot commented Apr 6, 2024

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added Stale and removed Stale labels Apr 6, 2024
@mikehardy
Copy link
Collaborator

still alive

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy approve as it's backwards compatible, thank you!

@mikehardy mikehardy merged commit d9987da into invertase:main Apr 12, 2024
17 of 19 checks passed
@mnahkies mnahkies deleted the mn/fix/enrollmentTime-ios branch April 20, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants