chore(android)!: forward-port to new architecture method #1150
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
added
pending-merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 556 579 +23
=======================================
Hits 1331 1331
Misses 395 395
Partials 1 1 |
The method to forward-port to was added in react-native 0.65 so this is breaking but should not actually affect anyone BREAKING CHANGE: minimum required react-native now 0.65
mikehardy
force-pushed
the
react-native-deprecation-drop-pre-0.65
branch
from
9ad5b86 to
41fd91f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port away from deprecated react-native method
The one we need to use now were added in react-native 0.65
facebook/react-native@dfa8eb0
react-native 0.65 was released in August 2021 so this shouldn't actually affect anyone but every time I think that I am surprised
Blocking this one pending other breaking changes, as there is not a pressing need to release it now, I just noticed it while troubleshooting and testing #1149