Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ios): - Improve Remote Notification Support section #1120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LunatiqueCoder
Copy link

@LunatiqueCoder LunatiqueCoder commented Oct 10, 2024

Hello!

A little revamp on the docs, added what tricks helped me, also mentioned what issued I ran into, etc etc.

Here are some main changes:

  • Improved overall steps
  • Added community Expo config plugins
  • Added Swift example
  • Added Apple Doc links
  • Improved payload example

You can see the new README here:
https://github.com/LunatiqueCoder/notifee/blob/patch-1/docs-react-native/react-native/docs/ios/remote-notification-support.md

Hope you'll like it

Cheers 🍻

@LunatiqueCoder LunatiqueCoder changed the title docs(ios) - Improve Remote Notification Support section docs(ios): - Improve Remote Notification Support section Oct 10, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of little nitpicks here and there but in general I really like this

Do you think you can incorporate these suggestions? A lot of them may be incorporated directly but some of them need to be manually added as they move things around just a little bit I think

Thank you!


<br>

Before moving to the next step, run the app and check it builds successfully – make sure you have the correct target selected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like this suggestion here again - so they do a build test once before they try to do custom code, and now they do another build test after trying to make custom code but before moving on

@mikehardy mikehardy added ios needs-feedback Waiting on response to questions docs labels Oct 18, 2024
@LunatiqueCoder
Copy link
Author

Niiice. I resolved those ones that I just mostly copy pasted from you. Feel free to unresolve or come with other comments/suggestions. :)

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Nov 27, 2024
@github-actions github-actions bot closed this Dec 12, 2024
@mikehardy
Copy link
Collaborator

still working through new-arch problems sadly, but in this repo - I'm here, just everything taking time

@mikehardy mikehardy reopened this Dec 12, 2024
@mikehardy mikehardy added Keep Open this label avoids the stale bot and removed Stale labels Dec 12, 2024
@mikehardy
Copy link
Collaborator

finally got the docs publishing here again, on the docs.page platform - just finished that today - one step closer on all this backlog here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ios Keep Open this label avoids the stale bot needs-feedback Waiting on response to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants