[dss] scd: inline oir deletion implicit subscription cleanup into CRDB calls #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
inline-oir-deletion-implicit-removal-clean
branch
from
ee8be76
to
565475d
Compare
Shastick
force-pushed
the
inline-oir-deletion-implicit-removal-clean
branch
from
565475d
to
9e399b3
Compare
|
Doesn't this qualify as relying more on CRDB? Is this acceptable? Also for #1064 |
Any storage backend that offers an SQL interface and supports transactions should work with this: subqueries are a feature of the SQL standard and not limited to CRDB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #1059
This pushes down the Go logic added in #1104 into CRDB my means of sub-requests.
The new qualifier scenario checking for implicit sub cleanups succeeds on this PR when ran locally.