fix: TensorFlow explainers have the same signature as the rest #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asendotsinski
force-pushed
the
tf-explainer-signatures
branch
3 times, most recently
from
010f2bb
to
6a077eb
Compare
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
gaugup
reviewed
Oct 31, 2023
There was a problem hiding this comment.
@asendotsinski could you please look at the linting failures in your PR?
Right now the TensorFlow gradient explainers do not implement the `_generate_counterfactuals` method from the `BaseExplainer` class. This means that: 1) You cannot instantiate object of class `DiceTensorFlow(1/2)` without replacing the `__class__` of another method, because it is not a valid child of `ExplainerBase`. 2) By overriding the parent `generate_counterfactuals` method, the two classes bypass any validation steps that would normally be carried out by the base class (e.g. checking that the number of CF queries is non-negative). Signed-off-by: Asen Dotsinski <[email protected]>
asendotsinski
force-pushed
the
tf-explainer-signatures
branch
from
6a077eb
to
47e507a
Compare
|
@gaugup It should be good now, I checked the linter locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the TensorFlow gradient explainers do not implement the
_generate_counterfactualsmethod from theBaseExplainerclass. This means that:1) You cannot instantiate object of class
DiceTensorFlow(1/2)without replacing the__class__of another method, because it is not a valid child
of
ExplainerBase.2) By overriding the parent
generate_counterfactualsmethod, the two classes bypass any validation steps
that would normally be carried out by the base class
(e.g. checking that the number of CF queries is non-negative).
I believe this to be in error, is it on purpose?