Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WM on Test wallet #1427
feat: WM on Test wallet #1427
Changes from 63 commits
01d9084
ee0bb17
da749f5
261ce75
a06af49
2078190
c14b686
fb4986d
bb35ecf
eea0694
c01d1a6
b3429ac
07a1ea3
9eeeec9
0cbdf04
22c77a5
ac3be50
4876690
4caaaa4
83ed0c5
b2b14ce
2626bfc
e52bd16
6c5d9a3
4c0de74
1768d9e
3aa2ce8
70fb990
e5f6cc8
ac844d1
7c5eee5
7cd87d4
3733fa6
3c410d8
ff4b64e
2bad249
6e6b7f4
7e6c73b
3d2189d
317d2a3
e450145
7fdb4fe
b78f24d
308306e
dfbf7f3
021c9b8
b920316
4601b42
1593a26
ed44242
ba0ff7b
29cc5e9
8b1f95f
1f81cc6
db4de9c
df198f3
9723429
27f32c3
3925b62
e81c0f5
650a72f
119e4da
b78cf23
79fd71a
d9e4d9a
939b7f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified this to
0.01
(which is the lowest non-zero amount representable in asset scale 2) instead of0.1
. Any reason to change it back?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this so that I can migrate assets to scale 9 in the
assets
table which is inrafiki_backend
db. That requires a separate connection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an env variable instead with the connection string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would asset code change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens because
assetCode
wasnull
for every WA for some reason and that was causingkeepBalancesSynced
to fail when checking that asset code exists for every WA. Until now, we only populatedassetCode
column on WAs table for WM payment pointers. Therefore, I changed the asset code fromnull
to whatever asset code the account has when migrating to prevent issues.