-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring asset response type into shared package #1361
Conversation
@@ -0,0 +1,19 @@ | |||
export type Asset = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these types used in backend as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1351
The Types shared here should be imported in the backend to be used as the response type of controllers,
and also in the frontend in order to import and not duplicate response types.
So i believe these types should also be added to the controllers?
The shared package between backend and frontend should export:
As it is now currently used in places such as. Each call from our FE to our BE should type the response with the above construct, instead of writing the response type in the FE. |
Keeping in mind the other places that need to have the types moved to shared: #1351 My suggestion would be to have the interfaces in shared have a conventional name, like including "Response" in it such as "NameResponse" So that in the "account" implementation for example we would have the "Account" type being used for the bussiness logic inside the backend, and that is not shared, but for the controller response type we would have "AccountResponse" Wdyt? |
change response names
change response names
Context
Changes