Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): make the rafiki wallet url case insensitive #2833

Merged
merged 18 commits into from
Sep 18, 2024
Merged

fix(backend): make the rafiki wallet url case insensitive #2833

Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f669c49
wallet address url stored in database converted to lower case (packag…
s100tist Jul 19, 2024
7b5e936
Merge branch 'interledger:main' into backend-case-insensitiveness
s100tist Aug 1, 2024
534a3f0
correcting formating
s100tist Aug 19, 2024
094e900
Merge branch 'backend-case-insensitiveness' of https://github.com/s10…
s100tist Aug 19, 2024
ad8cfac
rollback of to lower case in openpayments/walletaddress/middleware an…
s100tist Aug 19, 2024
3c15536
Max suggestion
s100tist Aug 19, 2024
18fcf95
Removing logs:(
s100tist Aug 21, 2024
c239662
Update service.ts
s100tist Aug 21, 2024
a28c2de
query corrected
s100tist Aug 21, 2024
9139886
return deleted
s100tist Aug 26, 2024
c500f2b
using toLowerCase in the request
s100tist Aug 29, 2024
d1c3ac2
Merge branch 'interledger:main' into backend-case-insensitiveness
s100tist Aug 29, 2024
d56bf8e
Merge branch 'backend-case-insensitiveness' of https://github.com/s10…
s100tist Aug 29, 2024
aec3467
format changes
s100tist Aug 29, 2024
ab6c339
tests for wallet address draft
s100tist Sep 4, 2024
7e9b8a6
tests added
s100tist Sep 12, 2024
53d7871
duplied wallet addresses handling
s100tist Sep 17, 2024
53b0c8c
Update packages/backend/src/open_payments/wallet_address/errors.ts
s100tist Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/backend/src/open_payments/wallet_address/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ async function createWalletAddress(

return await WalletAddress.query(deps.knex)
.insertGraphAndFetch({
url: options.url,
url: options.url.toLowerCase(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add some tests for these :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s100tist
in the catch statement, you can check for err instanceof UniqueViolationError to catch those cases where you are trying to create a duplicate wallet address

publicName: options.publicName,
assetId: options.assetId,
additionalProperties: additionalProperties
Expand Down Expand Up @@ -296,7 +296,7 @@ async function getWalletAddressByUrl(
url: string
): Promise<WalletAddress | undefined> {
const walletAddress = await WalletAddress.query(deps.knex)
.findOne({ url })
.findOne({ url: url.toLowerCase() })
.withGraphFetched('asset')
return walletAddress || undefined
}
Expand Down