-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): make the rafiki wallet url case insensitive #2833
Merged
mkurapov
merged 18 commits into
interledger:main
from
s100tist:backend-case-insensitiveness
Sep 18, 2024
Merged
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f669c49
wallet address url stored in database converted to lower case (packag…
s100tist 7b5e936
Merge branch 'interledger:main' into backend-case-insensitiveness
s100tist 534a3f0
correcting formating
s100tist 094e900
Merge branch 'backend-case-insensitiveness' of https://github.com/s10…
s100tist ad8cfac
rollback of to lower case in openpayments/walletaddress/middleware an…
s100tist 3c15536
Max suggestion
s100tist 18fcf95
Removing logs:(
s100tist c239662
Update service.ts
s100tist a28c2de
query corrected
s100tist 9139886
return deleted
s100tist c500f2b
using toLowerCase in the request
s100tist d1c3ac2
Merge branch 'interledger:main' into backend-case-insensitiveness
s100tist d56bf8e
Merge branch 'backend-case-insensitiveness' of https://github.com/s10…
s100tist aec3467
format changes
s100tist ab6c339
tests for wallet address draft
s100tist 7e9b8a6
tests added
s100tist 53d7871
duplied wallet addresses handling
s100tist 53b0c8c
Update packages/backend/src/open_payments/wallet_address/errors.ts
s100tist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add some tests for these :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s100tist
in the catch statement, you can check for
err instanceof UniqueViolationError
to catch those cases where you are trying to create a duplicate wallet address