fix: add og tags to site #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huijing
commented
Aug 14, 2024
| @@ -2,6 +2,7 @@ | |||
| layout: ../../layouts/BlogLayout.astro | |||
| title: "The Interledger Universe" | |||
| description: "Or: “What the heck are all those products and protocols?”" | |||
| ogImageUrl: /developers/img/blog/2024-08-13/og-image.png | |||
There was a problem hiding this comment.
New frontmatter field that gets used in the BlogLayout template.
huijing
commented
Aug 14, 2024
| @@ -21,6 +24,12 @@ const { title, description } = Astro.props; | |||
| <meta name="viewport" content="width=device-width" /> | |||
| <meta name="generator" content={Astro.generator} /> | |||
| <title>{title ? `${title} | Interledger Foundation` : 'Interledger Foundation'}</title> | |||
|
|
|||
| <meta property="og:title" content={title ? `${title} | Interledger Foundation` : 'Interledger Foundation'} /> | |||
There was a problem hiding this comment.
Exposing ogType to the next layer down because I want individual blog posts to have type of article. Similar concept for the og-image.
huijing
commented
Aug 14, 2024
src/layouts/BlogLayout.astro
Outdated
| @@ -10,7 +10,7 @@ const longDate = dateObj.toDateString().substring(4); | |||
| const rawHTMLString = `This article was originally published at <a href=${frontmatter.external_url}>${frontmatter.external_url}</a>.` | |||
| --- | |||
|
|
|||
| <BaseLayout title={frontmatter.title}> | |||
| <BaseLayout title={frontmatter.title} ogType="article" ogImageUrl={frontmatter.ogImageUrl ? new URL(frontmatter.ogImageUrl, Astro.site).href : new URL('/img/og-image.png', Astro.site).href}> | |||
There was a problem hiding this comment.
Passing props all the way like turtles (bad reference, oh well)
JoblersTune
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Sabine requested the receiver move down toward the ZAR node.
|
Waiting for default OG image for engineering blog |
JoblersTune
approved these changes
Aug 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
This PR sets up the OG tags for /developers and allows more granular customisation at the individual blog post level.