Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement new API to also handle multiple transcoding outputs #8

Merged
merged 8 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/ci.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.0', '3.1', '3.2', '3.3']
ffmpeg-version: ['7.0.2', '6.0.1', '5.1.1', '4.4.1']
ruby-version: ['3.1', '3.2', '3.3']
ffmpeg-version: ['release', '6.0.1', '5.1.1', '4.4.1']

include:
- ffmpeg-version: '7.0.2'
download-path: 'releases'
version-name: 'release'
- ffmpeg-version: 'release'
ffmpeg-download-path: 'releases'

steps:
- uses: actions/checkout@v4
Expand All @@ -32,14 +31,16 @@ jobs:
rubygems: latest

- name: Install FFMPEG
working-directory: /tmp
run: |
sudo apt-get update
sudo apt-get install -y wget
wget https://johnvansickle.com/ffmpeg/${{ matrix.download-path || 'old-releases' }}/ffmpeg-${{ matrix.version-name || matrix.ffmpeg-version }}-amd64-static.tar.xz
tar -xf ffmpeg-${{ matrix.version-name || matrix.ffmpeg-version }}-amd64-static.tar.xz
sudo mv ffmpeg-${{ matrix.ffmpeg-version }}-amd64-static/ffmpeg /usr/local/bin/ffmpeg
sudo mv ffmpeg-${{ matrix.ffmpeg-version }}-amd64-static/ffprobe /usr/local/bin/ffprobe
rm -rf ffmpeg-${{ matrix.version-name || matrix.ffmpeg-version }}-amd64-static.tar.xz ffmpeg-${{ matrix.ffmpeg-version }}-amd64-static
wget -O ffmpeg.tar.xz https://johnvansickle.com/ffmpeg/${{ matrix.ffmpeg-download-path || 'old-releases' }}/ffmpeg-${{ matrix.ffmpeg-version }}-amd64-static.tar.xz
mkdir ffmpeg
tar -xf ffmpeg.tar.xz --strip=1 -C ffmpeg
sudo mv ffmpeg/ffmpeg /usr/local/bin/ffmpeg
sudo mv ffmpeg/ffprobe /usr/local/bin/ffprobe
rm -rf ffmpeg.tar.xz ffmpeg

- name: Run RSpec
run: bundle exec rspec
5 changes: 4 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ inherit_from: .rubocop_todo.yml
AllCops:
NewCops: enable
SuggestExtensions: false
TargetRubyVersion: 3.0
TargetRubyVersion: 3.1

Metrics/AbcSize:
Enabled: false
Expand Down Expand Up @@ -38,5 +38,8 @@ Style/ArgumentsForwarding:
Style/FloatDivision:
Enabled: false

Style/RequireOrder:
Enabled: true

Style/SafeNavigationChainLength:
Enabled: false
1 change: 1 addition & 0 deletions .ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.3.6
kiskoza marked this conversation as resolved.
Show resolved Hide resolved
Loading