Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-progress): improve accessibilty on documentation main page #1784

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Nov 20, 2024

Closes:
INSTUI-4263
INSTUI-4265
INSTUI-4272

ISSUES:

  • Quick start/Github/Migration guide buttons are not in list tags but appear as list
  • "What's new?" section is nested within navigation landmark despite not being a top-level landmark
  • Instructure logo is nested within navigation landmark, but it isn't a top-level landmark
  • Instructure side menu container incorrectly has a heading tag

TEST PLAN:

  • check if Quick start/Github/Migration guide buttons are in list on the main page
  • check if "What's new?" section is a div instead of an aside tag on the main page
  • check if inside the navigation bar, the container of the Instructure logo does not have a banner role
  • check if container below the previous element is a div, not a h1 tag

Closes: INSTUI-4263, INSTUI-4265, INSTUI-4272
@ToMESSKa ToMESSKa self-assigned this Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-26 09:01 UTC

@ToMESSKa ToMESSKa merged commit e9b03b2 into master Nov 26, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4263_docs_quick_a11y_fixes branch November 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants