fix(emotion,shared-types): better TS types for theme objects and their overrides #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r overrides Also convert some of the final files in the docs app to TS and improve their typing TEST PLAN: Try to make various theme and override objects, they should have nice autocomplete and no errors
matyasf
commented
Nov 19, 2024
| @@ -87,3 +141,62 @@ export type { | |||
| GenerateStyle, | |||
| ComponentStyle | |||
| } | |||
| /* | |||
There was a problem hiding this comment.
I've left this here intentionally to test this complex type
matyasf
commented
Nov 19, 2024
| @@ -29,21 +29,75 @@ import type { | |||
| DeepPartial | |||
There was a problem hiding this comment.
The type changes in this file and the main change
|
matyasf
commented
Nov 19, 2024
| @@ -130,4 +130,4 @@ export { Drilldown } from '@instructure/ui-drilldown' | |||
| export { SourceCodeEditor } from '@instructure/ui-source-code-editor' | |||
| export { TopNavBar } from '@instructure/ui-top-nav-bar' | |||
| export { TruncateList } from '@instructure/ui-truncate-list' | |||
| export { canvas, canvasHighContrast, instructure } from '@instructure/ui-themes' | |||
There was a problem hiding this comment.
This was left here from v9... we really need to type check the docs app
matyasf
commented
Nov 19, 2024
| @@ -47,6 +46,19 @@ type AllowedPropKeys = Readonly<Array<PropKeys>> | |||
|
|
|||
| type DocumentProps = DocumentOwnProps & WithStyleProps<null, DocumentStyle> | |||
|
|
|||
| // TODO this does not match the TS type either fix or remove | |||
There was a problem hiding this comment.
This is just moved from /__docs__/src/propTypes.js
ToMESSKa
requested changes
Nov 19, 2024
Comment on lines
+51
to
+52
| // matches whitespace at the end of a string | ||
| line.replace(/\s*$/, '') |
There was a problem hiding this comment.
I think .replace() does not change the original string, so the whitespace isn't actually removed. The result should be reassigned e.g.: line = line.replace(/\s*$/, '')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also convert some of the final files in the docs app to TS and improve their typing
TEST PLAN:
Try to make various theme and override objects, they should have nice autocomplete and no errors