fix(ui-color-picker): make ColorPicker tooltip VoiceOver focusable

Closes: INSTUI-4259
instructure · Nov 20, 2024 · b8650f4 · b8650f4
1 parent 1209b0d
commit b8650f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/ui-color-picker/src/ColorPicker/index.tsx b/packages/ui-color-picker/src/ColorPicker/index.tsx
@@ -390,7 +390,7 @@ class ColorPicker extends Component<ColorPickerProps, ColorPickerState> {
         <span css={styles?.label}>{label}</span>
         <span>
           <Tooltip renderTip={tooltip}>
-            <IconInfoLine tabIndex={-1} />
+            <IconInfoLine aria-hidden={undefined} />
           </Tooltip>
         </span>
       </span>

diff --git a/packages/ui-svg-images/src/InlineSVG/index.tsx b/packages/ui-svg-images/src/InlineSVG/index.tsx
@@ -163,7 +163,6 @@ class InlineSVG extends Component<InlineSVGProps> {
     return (
       <svg
         {...parseAttributes(src)}
-        {...omitProps(this.props, InlineSVG.allowedProps, ['inline'])}
         style={{
           ...style,
           width,
@@ -174,6 +173,7 @@ class InlineSVG extends Component<InlineSVGProps> {
         aria-hidden={title ? undefined : 'true'}
         aria-labelledby={this.labelledBy}
         role={this.role}
+        {...omitProps(this.props, InlineSVG.allowedProps, ['inline'])}
         focusable={focusable ? 'true' : 'false'}
         css={styles?.inlineSVG}
         className={props.className}