Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Horizon] Fix tab bar on SE size #2982

Open
wants to merge 1 commit into
base: feature/horizon
Choose a base branch
from
Open

[Horizon] Fix tab bar on SE size #2982

wants to merge 1 commit into from

Conversation

Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93
Fix tab bar issue
2fe32ae 
[ignore-commit-lint]
@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Nov 22, 2024
@inst-danger
Copy link
Contributor

Horizon Build QR Code:

@inst-danger
Copy link
Contributor

Warnings
⚠️ One or more files are below the minimum test coverage 50%
⚠️ The total test coverage is below the minimum 90%
Coverage New % Master % Delta
Canvas iOS 90% 90.16% -0.16%
Core/Core/Courses/CourseProgression/CDCourseProgression.swift 0% -- --
Core/Core/Planner/CalendarMain/ViewModel/PlannerViewModel.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarWeek.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/View/Calendar/CalendarCardInteractionState.swift 0% 0% 0%
Core/Core/Courses/CourseProgression/GetCoursesProgressionRequest.swift 0% -- --
Core/Core/Planner/CalendarMain/Model/PlannablesInteractor.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/View/Calendar/ViewPreferences.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarDay.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarMonth.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/View/Calendar/CalendarUtils.swift 0% 0% 0%

Generated by 🚫 dangerJS against 2fe32ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabinst szabinst Awaiting requested review from szabinst szabinst is a code owner

@ktheory ktheory Awaiting requested review from ktheory ktheory is a code owner

@JacksonHowe JacksonHowe Awaiting requested review from JacksonHowe JacksonHowe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Ahmed-Naguib93 Ahmed-Naguib93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ahmed-Naguib93 @inst-danger