Fix media in offline rich content #2977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18070 affects: Student release note: Fixed images and Studio videos not being available for offline mode after an app update. test plan: - Sync rich content with images and studio videos. - Go offline and go to the rich content. - They should appear just as expected. - Check the offline html content with safari or with a breakpoint in CoreWebView.loadContent (look for the rawHtmlValue variable). - Urls should be all relative without the application's UUID container ID in it. - Check out the branch and install the app into the same phone to simulate an app update. - Start the app in offline mode, rich content should appear just as before. - Note: we can't test this with other builds because the base url for the offline webview have changed and other builds point to a different one.
vargaat
requested review from
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
Release Note:Fixed images and Studio videos not being available for offline mode after an app update. Affected Apps: Student
|
Student Build QR Code: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
HTMLDownloadInteractorentity to be easier to understand what it does.refs: MBL-18070
affects: Student
release note: Fixed images and Studio videos not being available for offline mode after an app update.
test plan:
Checklist