Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of user not being able to submit assignment when logged in root account #2976

Closed
wants to merge 9 commits into from

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Nov 19, 2024

refs: MBL-18064
affects: Student, Teacher
release note: Fixes issue of user not being able to submit assignment when logged in root account.

Test Plan

See ticket description.

Screen Record

Simulator.Screen.Recording.-.iPhone.16.-.2024-11-20.at.20.23.15.mp4

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@inst-danger
Copy link
Contributor

inst-danger commented Nov 19, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Fixes issue of user not being able to submit assignment when logged in root account

Affected Apps: Student

MBL-18064

Coverage New % Master % Delta
Canvas iOS 90.16% 90.16% -0%
Core/Core/Planner/CalendarMain/ViewModel/PlannerViewModel.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarWeek.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/View/Calendar/CalendarCardInteractionState.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/PlannablesInteractor.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/View/Calendar/ViewPreferences.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarDay.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/Model/CalendarMonth.swift 0% 0% 0%
Core/Core/Planner/CalendarMain/View/Calendar/CalendarUtils.swift 0% 0% 0%

Generated by 🚫 dangerJS against e731038

refs: MBL-18064
affects: Student
release note: Fixes issue of user not being able to submit assignment when logged in root account
@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review November 20, 2024 17:24
@suhaibabsi-inst suhaibabsi-inst self-assigned this Nov 21, 2024
Copy link
Contributor

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text submission worked fine but the file upload one still failed for me. The file was successfully uploaded but the submission itself failed with an internal server error. The successful submission went to apac-consortia-03 while the failed file upload and submission calls targeted apac-consortia. We should also consider the scenario when we submit files via the file share extensions.

Core/Core/Submissions/GetSubmissions.swift Outdated Show resolved Hide resolved
@inst-danger
Copy link
Contributor

inst-danger commented Nov 24, 2024

Student Build QR Code:

@vargaat
Copy link
Contributor

vargaat commented Nov 25, 2024

Teacher Build QR Code:

@suhaibabsi-inst suhaibabsi-inst marked this pull request as draft November 25, 2024 15:51
@suhaibabsi-inst
Copy link
Contributor Author

Closing this as it will be replaced with this one:
#2989

@suhaibabsi-inst suhaibabsi-inst deleted the bugfix/MBL-18064 branch November 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants