Preserve PDF annotations even when cache is reset #2965
+90
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18069 affects: Student release note: PDF annotations is preserved even when cache is reset test plan: See PR description
Student Build QR Code: |
Release Note:PDF annotations is preserved even when cache is reset Affected Apps: Student❌ Swift lint |
suhaibabsi-inst
requested review from
vargaat,
szabinst,
rh12 and
ndrsszsz
as code owners
vargaat
requested changes
Nov 13, 2024
suhaibabsi-inst
commented
Nov 14, 2024
ndrsszsz
previously approved these changes
Nov 14, 2024
rh12
reviewed
Nov 14, 2024
vargaat
reviewed
Nov 19, 2024
Core/CoreTests/Files/View/FileDetails/FileDetailsViewControllerTests.swift
Outdated
Show resolved
Hide resolved
…rTests.swift Co-authored-by: Attila Varga <[email protected]>
vargaat
requested changes
Nov 19, 2024
vargaat
requested changes
Nov 22, 2024
Core/Core/Login/LoginSession.swift
Outdated
|
|
||
| try? fileManager | ||
| .contentsOfDirectory(at: folderUrl, includingPropertiesForKeys: nil) | ||
| .filter({ $0.lastPathComponent.hasPrefix(URL.Paths.offline) == false }) |
There was a problem hiding this comment.
Thanks for the filtering here. My concern with this is that in case we want to save something in the user's session folder in the future it will be copied to the annotated pdf directory since this only excludes the offline folder.
All the annotated pdfs are saved in directories with only numbers in their names and the annotated files have a pdf extension. Could we use this knowledge to move only such directories?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18069
affects: Student
release note: PDF annotations is preserved even when cache is reset
Test Plan
Video Record
Recording covering PDF annotation persistence scenarios, which are:
pdf_annotations_saving.mov
Checklist