Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

feat: 馃幐 search filter by platform has implemented #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CeamKrier
Copy link
Member

@CeamKrier CeamKrier commented Nov 19, 2021

Search functionality implemented. Instead of search pills (tried it but could not come up with a good distinction for the social networks), a platform picker will be used to choose which sites users would love to search.

Features:

  • Selected search values will persist on local storage. Subsequent visits of the user will render the application pre-selected those values

Issues:

  • When users change the filter when already searched for some username, the application won't be handling "dynamic search" here. Instead, it will show the home screen, then expect the user to fill the search input again. I know it is cumbersome but I could not manage to get it to work with the current implementation. There might be something that I'm missing too, it is worth examining in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant