Updated Git actions workflow to label PR with InSpec major versions #6772
Conversation
Signed-off-by: Nik08 <[email protected]>
Signed-off-by: Nik08 <[email protected]>
✅ Deploy Preview for chef-inspec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| run: | | ||
| BASE_BRANCH="${{ github.event.pull_request.base.ref }}" | ||
| if [ "$BASE_BRANCH" == "main" ]; then | ||
| echo "::set-output name=base_branch_name::inspec-6" |
There was a problem hiding this comment.
This will not age well - we'll have to update this every time we have a new major version. I'm not sure how to get out of that, though. At least adding a comment would be good.
There was a problem hiding this comment.
Maybe I can read the VERSION file content, and fetch the major version from it and append "inspec-#{MAJOR VERSION}", when the base branch is main.
And for the rest, If the base branch starts with inspec- then just directly pick the base branch. This way it gets generic but it takes away our safe checks [ "$BASE_BRANCH" == "inspec-4" ] || [ "$BASE_BRANCH" == "inspec-5" ].
By this I mean, if by any chance someone creates a dummy branch with inspec- then it will create a label for that. It could be inspec-random-branch-name or inspec-100 etc..
There was a problem hiding this comment.
Will have to check though if reading file content is possible or not. I know matching is possible, will play around with reading content though.
…sion release Signed-off-by: Nik08 <[email protected]>
Description
Updated Git actions workflow to label PR based on the base branch.
The only base branches that are allowed are:
main,inspec-4andinspec-5Related Issue
Types of changes
Checklist: