feat: allow loading PdfWrap
from custom dynamic library
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
There has been some problems for me loading the dynamic library on Android platform. After checking, I realized that it was because
PdfWrap
loads the dynamic library at path'/libpdfium.so'
, but it should belibpdfium.so
. This is because:in the constructor.
While there are many ways of fixing this, I think that the simplest one of them is to just allow the user to specify the dynamic library and when the user does this, it overrides the logic of the dynamic library in the code.