-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support retries in e2e tests in CI #2145
Draft
jpraynaud
wants to merge
5
commits into
main
Choose a base branch
from
jpraynaud/2123-retries-e2e-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+177
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
from
November 27, 2024 15:39
edbd7d3
to
24062de
Compare
jpraynaud
temporarily deployed
to
testing-preview
November 27, 2024 15:49
— with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
November 27, 2024 15:49
— with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-preview
November 27, 2024 16:03
— with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
November 27, 2024 16:03
— with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
from
November 27, 2024 16:15
e752dd4
to
2724af6
Compare
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
from
November 27, 2024 16:22
2724af6
to
3520b73
Compare
jpraynaud
temporarily deployed
to
testing-preview
November 27, 2024 16:30
— with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
November 27, 2024 16:30
— with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
3 times, most recently
from
November 27, 2024 17:39
df45fe3
to
7676e66
Compare
jpraynaud
temporarily deployed
to
testing-preview
November 27, 2024 17:48
— with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
November 27, 2024 17:48
— with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
2 times, most recently
from
November 27, 2024 18:20
2301030
to
01bd176
Compare
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
from
November 27, 2024 18:29
01bd176
to
4154bff
Compare
jpraynaud
force-pushed
the
jpraynaud/2123-retries-e2e-test
branch
from
November 27, 2024 18:41
4154bff
to
d78c7a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes support for retrying e2e test runs in case of transient error on the Cardano network of the underlying devnet (which happen because of the custom configuration used for it). This will overall remove the main source of flakiness in the CI runs.
Error handling improvements:
mithril-test-lab/mithril-end-to-end/src/devnet/runner.rs
: IntroducedUnrecoverableDevnetError
and updated error handling inimpl Devnet
to use this new error type.Main execution flow restructuring:
mithril-test-lab/mithril-end-to-end/src/main.rs
: Refactored the main function to use a newAppResult
enum for handling different exit codes and added implementation forTermination
to map results to exit codes.Enhancements to GitHub workflows:
.github/workflows/backward-compatibility.yml
: Added retry logic to the E2E tests usingnick-fields/retry@v3
..github/workflows/ci.yml
: Added retry logic to the Test job usingnick-fields/retry@v3
.Pre-submit checklist
Issue(s)
Closes #2123