feat: add HW support for VP delegation #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }).promise; | ||
| if (wallet.isHardwareWallet) { | ||
| const [{ id: stakePoolId }] = this.stores.staking.stakePools; | ||
| let dlegationData: { |
There was a problem hiding this comment.
small typo. Just nitpicking, it could be ignored 😄
- let dlegationData: {
+ let delegationData: {| certificates = [ | ||
| { | ||
| certificateType: 'register_reward_account', | ||
| rewardAccountPath: ['1852H', '1815H', '0H', '2', '0'], |
There was a problem hiding this comment.
I am sorry. I am unfamiliar with Daedalus. Is it a single account wallet? (i.e. account is always '0H')
There was a problem hiding this comment.
Yes, that's correct. Daedalus is a single-account wallet.
szymonmaslowski
force-pushed
the
feat/LW-11519-governance-voting-tab-hw
branch
from
081f4ee to
f55834d
Compare
szymonmaslowski
force-pushed
the
feat/LW-11519-governance-voting-tab-hw
branch
from
f55834d to
4d719d6
Compare
szymonmaslowski
changed the title
szymonmaslowski
merged commit b4cdb15
into
feat/LW-11519-governance-voting-tab
3 of 5 checks passed
szymonmaslowski
added a commit
that referenced
this pull request
Nov 27, 2024
DominikGuzei
added a commit
that referenced
this pull request
Nov 27, 2024
* feat: Add navigation with governance to voting page [LW-11519] * feat: add delegate votes API call and integrate it with mobx voting store * feat: Add governance voting form [LW-11519] * feat: voting power delegation confirmation dialog * chore: Add changelog entry [LW-11519] * feat: useconstructTx endpoint to calculate fee and for HWs, fix validation in form, improve styling * feat: Recognize and style voting transactions [LW-11519] * feat: redirect the user to the wallet of coice after successfull VP delegation * feat: add i18n to confirmation dialog and handle API error cases * feat: Track successfully casted votes [LW-11519] * feat: add final translations [LW-11519] * fix: Catch send error for staking conway wallets which have not registered voting rights yet [LW-11518] * feat: add HW support for VP delegation (#3243) * feat: add ledger support for VP delegation * feat: add trezor support for VP delegation --------- Signed-off-by: Dominik Guzei <[email protected]> Co-authored-by: Szymon Masłowski <[email protected]> Co-authored-by: Przemysław Włodek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ledger devices. Trezor is on the way.