Fix missing tilde #1668
Merged
Fix missing tilde #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to open this from debauchee/barrier#1711 since it didn't seem like anyone else was doing it. Seems like a simple enough fix. I'm not familiar enough with JIS layouts to know if this might cause some other issue, but it certainly is better (for me) than having non-working tilde and backticks. |
|
A couple of feedback:
|
|
Alternatively, I can rebase and edit the commits myself, and force-push to the PR - we have access to do so. Would that be preferable? |
This was copied from debauchee/barrier#1711 by @dgentry. Resolves input-leap#1541 and input-leap#1407. Signed-off-by: Dom Rodriguez <[email protected]>
shymega
force-pushed
the
fix_missing_tilde
branch
from
882b98f
to
c67fc3a
Compare
|
I didn't hear back, and because we have a lot of PRs left, I decided to rebase, squash the two commits, amend the main commit, and rebase against mainline. Once checks pass, we can look at merging. |
p12tic
approved these changes
Sep 1, 2023
|
This is great, thank you. |
|
hey, sorry for leaving this hanging. I appreciate you proceeding! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken Tilde and Grave (Backtick/Backquote)
This was copied from debauchee/barrier#1711 by
@dgentry.
Resolves #1541 and #1407.
Contributor Checklist:
doc/newsfragmentsdirectory IF it is auser-visible change (and make sure to read the
README.mdin that directory)