-
Notifications
You must be signed in to change notification settings - Fork 64
Replace custom authentication with devise #35
base: main
Are you sure you want to change the base?
Conversation
Unfortunately, this is not ready to be merged in yet. |
There were couple of bugs that have now been fixed:
To fix both of these issues and to simplify the code, I've converted the |
@vfonic Some questions:
I'm hesitant to merge this, because it's pretty heavy weight for the needs of this app. Devise also makes it seem like a multi-user app which this is not. I'm pretty sure devise also uses bcrypt under the hood. |
You're right, the app, at the moment, is rather simple. I wouldn't mind expanding it further and adding more features to it. With more features being added, there will be added complexity of course.
Having a |
Good job on writing password encrypting algorithm that's compatible with default devise's encrypting algorithm!
I've added devise because I'm always afraid to write my own authentication. Devise is battle tested and works.
Plus, I was constantly being logged out on my phone so that was annoying, since I use quite long password that's difficult to type on the phone.
Plus, the login was case-sensitive and on my phone, the first letter was capitalized so I'd have to downcase it while typing.
This fixes all of the above issues while keeping the backwards compatibility with the existing users/databases. :)