Skip to content

Commit

Permalink
temporarily disabled signing
Browse files Browse the repository at this point in the history
  • Loading branch information
inlife committed Feb 6, 2024
1 parent 0fef352 commit 61a8eec
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 48 deletions.
92 changes: 46 additions & 46 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,57 +25,57 @@ jobs:
- name: Build binaries
run: npm run pkg

- name: Sign and notarize the nexrender-cli-macos
uses: toitlang/[email protected]
with:
certificate: ${{ secrets.MACOS_CERTIFICATE }}
certificate-password: ${{ secrets.MACOS_CERTIFICATE_PWD }}
username: ${{ secrets.APPLE_ID_USERNAME }}
password: ${{ secrets.APPLE_ID_PASSWORD }}
apple-team-id: 89QX7NXPQM
app-path: bin/nexrender-cli-macos
# - name: Sign and notarize the nexrender-cli-macos
# uses: toitlang/[email protected]
# with:
# certificate: ${{ secrets.MACOS_CERTIFICATE }}
# certificate-password: ${{ secrets.MACOS_CERTIFICATE_PWD }}
# username: ${{ secrets.APPLE_ID_USERNAME }}
# password: ${{ secrets.APPLE_ID_PASSWORD }}
# apple-team-id: 89QX7NXPQM
# app-path: bin/nexrender-cli-macos

# - name: Sign and notarize the nexrender-worker-macos
- name: Code sign (nexrender-worker-macos)
shell: bash
run: |
security find-identity -v signing_temp.keychain | grep "89QX7NXPQM" | grep "Developer ID Application"
codesign --keychain signing_temp.keychain --force --deep --sign "89QX7NXPQM" "bin/nexrender-worker-macos" --options=runtime
# # - name: Sign and notarize the nexrender-worker-macos
# - name: Code sign (nexrender-worker-macos)
# shell: bash
# run: |
# security find-identity -v signing_temp.keychain | grep "89QX7NXPQM" | grep "Developer ID Application"
# codesign --keychain signing_temp.keychain --force --deep --sign "89QX7NXPQM" "bin/nexrender-worker-macos" --options=runtime

- name: Create a tmp directory
id: tmp2
shell: bash
run: |
echo "path=$(mktemp -d -t sign_notarize.XXXXXXXXXX)" >> $GITHUB_OUTPUT
# - name: Create a tmp directory
# id: tmp2
# shell: bash
# run: |
# echo "path=$(mktemp -d -t sign_notarize.XXXXXXXXXX)" >> $GITHUB_OUTPUT

- name: Create a ZIP (nexrender-worker-macos)
id: zip2
shell: bash
run: |
TMP=${{ steps.tmp2.outputs.path }}
ZIP_PATH="$TMP/app2.zip"
zip -j "$ZIP_PATH" "bin/nexrender-worker-macos"
echo "zip_path=$ZIP_PATH" >> $GITHUB_OUTPUT
# - name: Create a ZIP (nexrender-worker-macos)
# id: zip2
# shell: bash
# run: |
# TMP=${{ steps.tmp2.outputs.path }}
# ZIP_PATH="$TMP/app2.zip"
# zip -j "$ZIP_PATH" "bin/nexrender-worker-macos"
# echo "zip_path=$ZIP_PATH" >> $GITHUB_OUTPUT

- name: Notarize (nexrender-worker-macos)
shell: bash
run: |
TMP=${{ steps.tmp2.outputs.path }}
xcrun notarytool submit \
"${{ steps.zip2.outputs.zip_path }}" \
--wait \
--apple-id "${{ secrets.APPLE_ID_USERNAME }}" \
--password "${{ secrets.APPLE_ID_PASSWORD }}" \
--team-id "89QX7NXPQM" \
--output-format json \
| tee "$TMP/out.json"
grep -q "Accepted" "$TMP/out.json"
# - name: Notarize (nexrender-worker-macos)
# shell: bash
# run: |
# TMP=${{ steps.tmp2.outputs.path }}
# xcrun notarytool submit \
# "${{ steps.zip2.outputs.zip_path }}" \
# --wait \
# --apple-id "${{ secrets.APPLE_ID_USERNAME }}" \
# --password "${{ secrets.APPLE_ID_PASSWORD }}" \
# --team-id "89QX7NXPQM" \
# --output-format json \
# | tee "$TMP/out.json"
# grep -q "Accepted" "$TMP/out.json"

- name: Check notarization (nexrender-worker-macos)
shell: bash
run: |
# See https://developer.apple.com/forums/thread/130560
codesign -vvvv -R="notarized" --check-notarization "bin/nexrender-worker-macos"
# - name: Check notarization (nexrender-worker-macos)
# shell: bash
# run: |
# # See https://developer.apple.com/forums/thread/130560
# codesign -vvvv -R="notarized" --check-notarization "bin/nexrender-worker-macos"

- name: Publish release
uses: softprops/action-gh-release@v1
Expand Down
1 change: 1 addition & 0 deletions out.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"status":"Invalid","message":"Processing complete","id":"fb3442cb-259d-4ee6-8f6b-91469f1cd87d"}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"publish": "lerna publish",
"public-publish": "lerna exec 'npm publish --access public'",
"pkg-rename": "node misc/rename.js",
"pkg-cli": "cross-env NEXRENDER_REQUIRE_PLUGINS=1 pkg packages/nexrender-cli/package.json --no-signature --out-path bin/",
"pkg-worker": "cross-env NEXRENDER_REQUIRE_PLUGINS=1 pkg packages/nexrender-worker/package.json --no-signature --out-path bin/",
"pkg-cli": "cross-env NEXRENDER_REQUIRE_PLUGINS=1 pkg packages/nexrender-cli/package.json --out-path bin/",
"pkg-worker": "cross-env NEXRENDER_REQUIRE_PLUGINS=1 pkg packages/nexrender-worker/package.json --out-path bin/",
"pkg-server": "cross-env NEXRENDER_REQUIRE_PLUGINS=1 pkg packages/nexrender-server/package.json --out-path bin/",
"pkg-prelink": "lerna run --scope @nexrender/core pkg-prelink && lerna run --scope @nexrender/server pkg-prelink",
"pkg": "npm run pkg-prelink && npm run pkg-cli && npm run pkg-server && npm run pkg-worker && npm run pkg-rename",
Expand Down

0 comments on commit 61a8eec

Please sign in to comment.