fix: ur not cleaned up when deleting namespaced policy

[sandeshlmore]

Signed-off-by: Sandesh More [email protected]

Explanation

Currently same handler function is used in both ClusterPolicy and Policy deletion, due to which a type error prevents clean up of UR while policy deletion.

Related issue

closes: 5101

Milestone of this PR

What type of PR is this

bug

Proposed Changes

Added seperate handler for Namespaced Policy deletion which takes care of UR clean up.

Proof Manifests

1. Create the poltest Namespace.
2. Create this Policy.

apiVersion: kyverno.io/v2beta1
kind: Policy
metadata:
  name: pol-sync-data
  namespace: poltest
spec:
  rules:
  - name: gen-zk
    match:
      any:
      - resources:
          kinds:
          - Secret
    generate:
      synchronize: true
      apiVersion: v1
      kind: ConfigMap
      name: zk
      namespace: poltest
      data:
        kind: ConfigMap
        metadata:
          labels:
            somekey: somevalue
        data:
          ZK_ADDRESS: "192.168.10.10:2181,192.168.10.11:2181,192.168.10.12:2181"
          KAFKA_ADDRESS: "192.168.10.13:9092,192.168.10.14:9092,192.168.10.15:9092"

3. Create a Secret which triggers this rule.
   $ k -n poltest create secret generic noodles --from-literal=foo=bar
4. Delete the Policy.
   $ k -n poltest delete pol pol-sync-data
5. See the complete UR is removed:
   $ k -n kyverno get ur

Checklist

• I have read the contributing guidelines.
• I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
• This is a bug fix and I have added unit tests that prove my fix is effective.
• This is a feature and I have added CLI tests that are applicable.
• My PR needs to be cherry picked to a specific release branch which is .
• My PR contains new or altered behavior to Kyverno and
  • CLI support should be added and my PR doesn't contain that functionality.
  • I have added or changed the documentation myself in an existing PR and the link is:
  • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

[shahpratikr]

don't we need to add any unit test for this?

[ApsTomar]

can we put a return here, so that rest of the code can come out of else block?

[sandeshlmore]

Done.

[ApsTomar]

It will be good if we can write unit tests for deleteNSPolicy function?

[sandeshlmore]

Unit test cant be added for this function. i tried with fake client as well.