-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/JA-112 BrowseServiceTests #102
Merged
Merged
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8caa8bf - Browse repository at this point
Copy the full SHA 8caa8bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3fa6d1 - Browse repository at this point
Copy the full SHA b3fa6d1View commit details -
Add test to BrowseServiceTests for invalid request case
Test - GetBrowseAdsPage_WhenRequestIsInvalid_ShouldReturnUnsuccessfulResponse
Configuration menu - View commit details
-
Copy full SHA for db14799 - Browse repository at this point
Copy the full SHA db14799View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3784419 - Browse repository at this point
Copy the full SHA 3784419View commit details -
Configuration menu - View commit details
-
Copy full SHA for df0c4d4 - Browse repository at this point
Copy the full SHA df0c4d4View commit details -
Add 4 tests to BrowseServiceTests for GetBrowseAdsPage
Tests: - GetBrowseAdsPage_WhenPageNumberIsLargerThanAvailable_ShouldReturnLastPage - GetBrowseAdsPage_WhenRequestIsValid_ShouldReturnCorrectNumberOfAds - GetBrowseAdsPage_WhenRequestIsValid_ShouldReturnCorrectTotalPages - GetBrowseAdsPage_WhenRequestIsValid_ShouldReturnCorrectAds
Configuration menu - View commit details
-
Copy full SHA for a05d230 - Browse repository at this point
Copy the full SHA a05d230View commit details -
Add 6 tests to BrowseServiceTests for GetAdDetails
Tests: - GetAdDetails_WhenAdDoesntExist_ShouldReturnNull - GetAdDetails_WhenUserIsOwner_ShouldReturnCorrectUserRelationship - GetAdDetails_WhenUserIsAcceptedStudent_ShouldReturnCorrectUserRelationship - GetAdDetails_WhenUserIsPendingStudent_ShouldReturnCorrectUserRelationship - GetAdDetails_WhenUserIsHasNoRelationshipToAd_ShouldReturnCorrectUserRelationship - GetAdDetails_WhenAdExists_ShouldReturnCorrectAdDetails Also added 1 helper method - SetupMockGetAdById
Configuration menu - View commit details
-
Copy full SHA for 206487c - Browse repository at this point
Copy the full SHA 206487cView commit details -
Add 8 tests to BrowseServiceTests for GetUsersSchedule
- GetUsersSchedule_WhenUserHasNoAds_ShouldReturnEmptyTutorsSchedule - GetUsersSchedule_WhenUserHasNoScheduleItemRequests_ShouldReturnEmptyStudentsSchedule - GetUsersSchedule_WhenUserHasAdsWithScheduleItems_ShouldReturnCorrectTutorsSchedule - GetUsersSchedule_WhenUserHasScheduleItemRequests_ShouldReturnCorrectStudentsSchedule - GetUsersSchedule_WhenNoStudentIsAccepted_ShouldReturnNullAcceptedStudentsName - GetUsersSchedule_WhenAStudentIsAccepted_ShouldReturnStudentsName - GetUsersSchedule_WhenRequestIsAccepted_ShouldReturnCorrectStatus - GetUsersSchedule_WhenRequestIsPending_ShouldReturnCorrectStatus Also added and modified some helper methods.
Configuration menu - View commit details
-
Copy full SHA for 12cd2a5 - Browse repository at this point
Copy the full SHA 12cd2a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e917e0 - Browse repository at this point
Copy the full SHA 4e917e0View commit details
Commits on May 22, 2024
-
Fix some issues in BrowseServiceTests
- Change in method name - Fixed incorrect assertion - Spacing adjustments - Added and renamed some actual and expected variables
Configuration menu - View commit details
-
Copy full SHA for 5a64d37 - Browse repository at this point
Copy the full SHA 5a64d37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f77c33 - Browse repository at this point
Copy the full SHA 8f77c33View commit details
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0085b64 - Browse repository at this point
Copy the full SHA 0085b64View commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 090ff4e - Browse repository at this point
Copy the full SHA 090ff4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0b8ce0 - Browse repository at this point
Copy the full SHA d0b8ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e453674 - Browse repository at this point
Copy the full SHA e453674View commit details -
Configuration menu - View commit details
-
Copy full SHA for f75448c - Browse repository at this point
Copy the full SHA f75448cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0479ec4 - Browse repository at this point
Copy the full SHA 0479ec4View commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c8343d - Browse repository at this point
Copy the full SHA 6c8343dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b5a960 - Browse repository at this point
Copy the full SHA 2b5a960View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.